From bb1f2d02c5cf5ffd3389ecee74af998cfedcc55b Mon Sep 17 00:00:00 2001
From: Marc Brugger <github@bakito.ch>
Date: Wed, 16 Apr 2025 12:51:27 +0200
Subject: [PATCH] fix: ignore empty config file in config validation (#561)

---
 pkg/config/validate.go      | 8 +++++++-
 pkg/config/validate_test.go | 5 +++++
 pkg/mocks/client/mock.go    | 6 +++---
 3 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/pkg/config/validate.go b/pkg/config/validate.go
index b15a80a..4532ecf 100644
--- a/pkg/config/validate.go
+++ b/pkg/config/validate.go
@@ -2,6 +2,7 @@ package config
 
 import (
 	_ "embed"
+	"fmt"
 	"os"
 	"strings"
 
@@ -17,19 +18,24 @@ var schemaData string
 func validateSchema(cfgFile string) error {
 	// ignore if file not exists
 	if _, err := os.Stat(cfgFile); err != nil {
+		// Config file does not exist or is not readable - ignore it
 		//nolint:nilerr
 		return nil
 	}
 	// Load YAML file
 	yamlContent, err := os.ReadFile(cfgFile)
 	if err != nil {
-		return err
+		return fmt.Errorf("config file %q is invalid: %w", cfgFile, err)
 	}
 
 	return validateYAML(yamlContent)
 }
 
 func validateYAML(yamlContent []byte) error {
+	if yamlContent == nil || strings.TrimSpace(string(yamlContent)) == "" {
+		return nil
+	}
+
 	// Convert YAML to JSON
 	var yamlData any
 	err := yaml.Unmarshal(yamlContent, &yamlData)
diff --git a/pkg/config/validate_test.go b/pkg/config/validate_test.go
index efc2dc1..decc5e7 100644
--- a/pkg/config/validate_test.go
+++ b/pkg/config/validate_test.go
@@ -36,5 +36,10 @@ var _ = Describe("Config", func() {
 			err = validateYAML(data)
 			Ω(err).ShouldNot(HaveOccurred())
 		})
+		It("validate config with empty file", func() {
+			var data []byte
+			err := validateYAML(data)
+			Ω(err).ShouldNot(HaveOccurred())
+		})
 	})
 })
diff --git a/pkg/mocks/client/mock.go b/pkg/mocks/client/mock.go
index 5db410e..bd513c6 100644
--- a/pkg/mocks/client/mock.go
+++ b/pkg/mocks/client/mock.go
@@ -496,7 +496,7 @@ func (mr *MockClientMockRecorder) SetSafeSearchConfig(settings any) *gomock.Call
 }
 
 // SetStatsConfig mocks base method.
-func (m *MockClient) SetStatsConfig(sc *model.GetStatsConfigResponse) error {
+func (m *MockClient) SetStatsConfig(sc *model.PutStatsConfigUpdateRequest) error {
 	m.ctrl.T.Helper()
 	ret := m.ctrl.Call(m, "SetStatsConfig", sc)
 	ret0, _ := ret[0].(error)
@@ -539,10 +539,10 @@ func (mr *MockClientMockRecorder) Stats() *gomock.Call {
 }
 
 // StatsConfig mocks base method.
-func (m *MockClient) StatsConfig() (*model.GetStatsConfigResponse, error) {
+func (m *MockClient) StatsConfig() (*model.PutStatsConfigUpdateRequest, error) {
 	m.ctrl.T.Helper()
 	ret := m.ctrl.Call(m, "StatsConfig")
-	ret0, _ := ret[0].(*model.GetStatsConfigResponse)
+	ret0, _ := ret[0].(*model.PutStatsConfigUpdateRequest)
 	ret1, _ := ret[1].(error)
 	return ret0, ret1
 }