feat(agents): implement model validation for agent and session creation/updating

src/main/apiServer/routes/agents/handlers/agents.ts

@@ -1,12 +1,20 @@
 import { loggerService } from '@logger'
+import { AgentModelValidationError, agentService } from '@main/services/agents'
 import { ListAgentsResponse,type ReplaceAgentRequest, type UpdateAgentRequest } from '@types'
 import { Request, Response } from 'express'
 
-import { agentService } from '../../../../services/agents'
 import type { ValidationRequest } from '../validators/zodValidator'
 
 const logger = loggerService.withContext('ApiServerAgentsHandlers')
 
+const modelValidationErrorBody = (error: AgentModelValidationError) => ({
+  error: {
+    message: `Invalid ${error.context.field}: ${error.detail.message}`,
+    type: 'invalid_request_error',
+    code: error.detail.code
+  }
+})
+
 /**
  * @swagger
  * /v1/agents:
@@ -50,6 +58,16 @@ export const createAgent = async (req: Request, res: Response): Promise<Response
     logger.info(`Agent created successfully: ${agent.id}`)
     return res.status(201).json(agent)
   } catch (error: any) {
+    if (error instanceof AgentModelValidationError) {
+      logger.warn('Agent model validation error during create:', {
+        agentType: error.context.agentType,
+        field: error.context.field,
+        model: error.context.model,
+        detail: error.detail
+      })
+      return res.status(400).json(modelValidationErrorBody(error))
+    }
+
     logger.error('Error creating agent:', error)
     return res.status(500).json({
       error: {
@@ -259,8 +277,8 @@ export const getAgent = async (req: Request, res: Response): Promise<Response> =
  *               $ref: '#/components/schemas/Error'
  */
 export const updateAgent = async (req: Request, res: Response): Promise<Response> => {
+  const { agentId } = req.params
   try {
-    const { agentId } = req.params
     logger.info(`Updating agent: ${agentId}`)
     logger.debug('Update data:', req.body)
 
@@ -283,6 +301,17 @@ export const updateAgent = async (req: Request, res: Response): Promise<Response
     logger.info(`Agent updated successfully: ${agentId}`)
     return res.json(agent)
   } catch (error: any) {
+    if (error instanceof AgentModelValidationError) {
+      logger.warn('Agent model validation error during update:', {
+        agentId,
+        agentType: error.context.agentType,
+        field: error.context.field,
+        model: error.context.model,
+        detail: error.detail
+      })
+      return res.status(400).json(modelValidationErrorBody(error))
+    }
+
     logger.error('Error updating agent:', error)
     return res.status(500).json({
       error: {
@@ -394,8 +423,8 @@ export const updateAgent = async (req: Request, res: Response): Promise<Response
  *               $ref: '#/components/schemas/Error'
  */
 export const patchAgent = async (req: Request, res: Response): Promise<Response> => {
+  const { agentId } = req.params
   try {
-    const { agentId } = req.params
     logger.info(`Partially updating agent: ${agentId}`)
     logger.debug('Partial update data:', req.body)
 
@@ -418,6 +447,17 @@ export const patchAgent = async (req: Request, res: Response): Promise<Response>
     logger.info(`Agent partially updated successfully: ${agentId}`)
     return res.json(agent)
   } catch (error: any) {
+    if (error instanceof AgentModelValidationError) {
+      logger.warn('Agent model validation error during partial update:', {
+        agentId,
+        agentType: error.context.agentType,
+        field: error.context.field,
+        model: error.context.model,
+        detail: error.detail
+      })
+      return res.status(400).json(modelValidationErrorBody(error))
+    }
+
     logger.error('Error partially updating agent:', error)
     return res.status(500).json({
       error: {

src/main/apiServer/routes/agents/handlers/sessions.ts

@@ -1,5 +1,9 @@
 import { loggerService } from '@logger'
-import { sessionMessageService, sessionService } from '@main/services/agents'
+import {
+  AgentModelValidationError,
+  sessionMessageService,
+  sessionService
+} from '@main/services/agents'
 import {
   CreateSessionResponse,
   ListAgentSessionsResponse,
@@ -12,9 +16,17 @@ import type { ValidationRequest } from '../validators/zodValidator'
 
 const logger = loggerService.withContext('ApiServerSessionsHandlers')
 
+const modelValidationErrorBody = (error: AgentModelValidationError) => ({
+  error: {
+    message: `Invalid ${error.context.field}: ${error.detail.message}`,
+    type: 'invalid_request_error',
+    code: error.detail.code
+  }
+})
+
 export const createSession = async (req: Request, res: Response): Promise<Response> => {
+  const { agentId } = req.params
   try {
-    const { agentId } = req.params
     const sessionData = req.body
 
     logger.info(`Creating new session for agent: ${agentId}`)
@@ -25,6 +37,17 @@ export const createSession = async (req: Request, res: Response): Promise<Respon
     logger.info(`Session created successfully: ${session.id}`)
     return res.status(201).json(session)
   } catch (error: any) {
+    if (error instanceof AgentModelValidationError) {
+      logger.warn('Session model validation error during create:', {
+        agentId,
+        agentType: error.context.agentType,
+        field: error.context.field,
+        model: error.context.model,
+        detail: error.detail
+      })
+      return res.status(400).json(modelValidationErrorBody(error))
+    }
+
     logger.error('Error creating session:', error)
     return res.status(500).json({
       error: {
@@ -120,8 +143,8 @@ export const getSession = async (req: Request, res: Response): Promise<Response>
 }
 
 export const updateSession = async (req: Request, res: Response): Promise<Response> => {
+  const { agentId, sessionId } = req.params
   try {
-    const { agentId, sessionId } = req.params
     logger.info(`Updating session: ${sessionId} for agent: ${agentId}`)
     logger.debug('Update data:', req.body)
 
@@ -157,6 +180,18 @@ export const updateSession = async (req: Request, res: Response): Promise<Respon
     logger.info(`Session updated successfully: ${sessionId}`)
     return res.json(session satisfies UpdateSessionResponse)
   } catch (error: any) {
+    if (error instanceof AgentModelValidationError) {
+      logger.warn('Session model validation error during update:', {
+        agentId,
+        sessionId,
+        agentType: error.context.agentType,
+        field: error.context.field,
+        model: error.context.model,
+        detail: error.detail
+      })
+      return res.status(400).json(modelValidationErrorBody(error))
+    }
+
     logger.error('Error updating session:', error)
     return res.status(500).json({
       error: {
@@ -169,8 +204,8 @@ export const updateSession = async (req: Request, res: Response): Promise<Respon
 }
 
 export const patchSession = async (req: Request, res: Response): Promise<Response> => {
+  const { agentId, sessionId } = req.params
   try {
-    const { agentId, sessionId } = req.params
     logger.info(`Patching session: ${sessionId} for agent: ${agentId}`)
     logger.debug('Patch data:', req.body)
 
@@ -204,6 +239,18 @@ export const patchSession = async (req: Request, res: Response): Promise<Respons
     logger.info(`Session patched successfully: ${sessionId}`)
     return res.json(session)
   } catch (error: any) {
+    if (error instanceof AgentModelValidationError) {
+      logger.warn('Session model validation error during patch:', {
+        agentId,
+        sessionId,
+        agentType: error.context.agentType,
+        field: error.context.field,
+        model: error.context.model,
+        detail: error.detail
+      })
+      return res.status(400).json(modelValidationErrorBody(error))
+    }
+
     logger.error('Error patching session:', error)
     return res.status(500).json({
       error: {