feat: make API server default to closed/disabled (#8691)
* ✨ feat: make API server default to closed/disabled - Add `enabled` field to ApiServerConfig interface with default value false - Update Redux store to include apiServer.enabled setting (defaults to false) - Add setApiServerEnabled action to control server state - Modify main process to only auto-start API server if explicitly enabled - Update UI to show enable/disable toggle in API server settings - Add migrations to handle existing configurations - Server controls now only visible when API server is enabled The API server will no longer start automatically on application launch unless explicitly enabled by the user through the settings interface. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * 🔧 chore: improve build and lint commands - Move typecheck and i18n checks to lint command for better developer experience - Simplify build:check to focus on linting and testing - Ensure all quality checks run together during development 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -22,12 +22,14 @@ class ConfigManager {
|
||||
})
|
||||
|
||||
this._config = {
|
||||
enabled: settings?.apiServer?.enabled ?? false,
|
||||
port: settings?.apiServer?.port ?? 23333,
|
||||
host: 'localhost',
|
||||
apiKey: generatedKey
|
||||
}
|
||||
} else {
|
||||
this._config = {
|
||||
enabled: settings?.apiServer?.enabled ?? false,
|
||||
port: settings?.apiServer?.port ?? 23333,
|
||||
host: 'localhost',
|
||||
apiKey: settings.apiServer.apiKey
|
||||
@@ -38,6 +40,7 @@ class ConfigManager {
|
||||
} catch (error: any) {
|
||||
logger.warn('Failed to load config from Redux, using defaults:', error)
|
||||
this._config = {
|
||||
enabled: false,
|
||||
port: 23333,
|
||||
host: 'localhost',
|
||||
apiKey: `cs-sk-${uuidv4()}`
|
||||
|
||||
+6
-2
@@ -143,9 +143,13 @@ if (!app.requestSingleInstanceLock()) {
|
||||
|
||||
// Start API server if enabled
|
||||
try {
|
||||
await apiServerService.start()
|
||||
const config = await apiServerService.getCurrentConfig()
|
||||
logger.info('API server config:', config)
|
||||
if (config.enabled) {
|
||||
await apiServerService.start()
|
||||
}
|
||||
} catch (error: any) {
|
||||
logger.error('Failed to start API server:', error)
|
||||
logger.error('Failed to check/start API server:', error)
|
||||
}
|
||||
})
|
||||
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
import { useTheme } from '@renderer/context/ThemeProvider'
|
||||
import { loggerService } from '@renderer/services/LoggerService'
|
||||
import { RootState, useAppDispatch } from '@renderer/store'
|
||||
import { setApiServerApiKey, setApiServerPort } from '@renderer/store/settings'
|
||||
import { setApiServerApiKey, setApiServerEnabled, setApiServerPort } from '@renderer/store/settings'
|
||||
import { IpcChannel } from '@shared/IpcChannel'
|
||||
import { Button, Input, InputNumber, Tooltip, Typography } from 'antd'
|
||||
import { Copy, ExternalLink, Play, RotateCcw, Square } from 'lucide-react'
|
||||
@@ -64,6 +64,7 @@ const ApiServerSettings: FC = () => {
|
||||
} catch (error) {
|
||||
window.message.error(t('apiServer.messages.operationFailed') + (error as Error).message)
|
||||
} finally {
|
||||
dispatch(setApiServerEnabled(enabled))
|
||||
setApiServerLoading(false)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1925,6 +1925,7 @@ const migrateConfig = {
|
||||
// Initialize API server configuration if not present
|
||||
if (!state.settings.apiServer) {
|
||||
state.settings.apiServer = {
|
||||
enabled: false,
|
||||
host: 'localhost',
|
||||
port: 23333,
|
||||
apiKey: `cs-sk-${uuid()}`
|
||||
|
||||
@@ -382,6 +382,7 @@ export const initialState: SettingsState = {
|
||||
navbarPosition: 'left',
|
||||
// API Server
|
||||
apiServer: {
|
||||
enabled: false,
|
||||
host: 'localhost',
|
||||
port: 23333,
|
||||
apiKey: `cs-sk-${uuid()}`
|
||||
@@ -791,6 +792,12 @@ const settingsSlice = createSlice({
|
||||
state.navbarPosition = action.payload
|
||||
},
|
||||
// API Server actions
|
||||
setApiServerEnabled: (state, action: PayloadAction<boolean>) => {
|
||||
state.apiServer = {
|
||||
...state.apiServer,
|
||||
enabled: action.payload
|
||||
}
|
||||
},
|
||||
setApiServerPort: (state, action: PayloadAction<number>) => {
|
||||
state.apiServer = {
|
||||
...state.apiServer,
|
||||
@@ -926,6 +933,7 @@ export const {
|
||||
setEnableDeveloperMode,
|
||||
setNavbarPosition,
|
||||
// API Server actions
|
||||
setApiServerEnabled,
|
||||
setApiServerPort,
|
||||
setApiServerApiKey
|
||||
} = settingsSlice.actions
|
||||
|
||||
@@ -842,6 +842,7 @@ export type S3Config = {
|
||||
export type { Message } from './newMessage'
|
||||
|
||||
export interface ApiServerConfig {
|
||||
enabled: boolean
|
||||
host: string
|
||||
port: number
|
||||
apiKey: string
|
||||
|
||||
Reference in New Issue
Block a user