From 414bc10c40ad1fb3e1f09209e75a16efc45686db Mon Sep 17 00:00:00 2001
From: Godfrey M <godmartinz@gmail.com>
Date: Thu, 15 Feb 2024 12:02:08 -0800
Subject: [PATCH] removes the double for loop with a better solution

---
 app/Http/Controllers/LabelsController.php | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/app/Http/Controllers/LabelsController.php b/app/Http/Controllers/LabelsController.php
index 7324a9f2a8..379836758b 100755
--- a/app/Http/Controllers/LabelsController.php
+++ b/app/Http/Controllers/LabelsController.php
@@ -27,7 +27,7 @@ class LabelsController extends Controller
     public function show(string $labelName)
     {
         $setting = Setting::getSettings();
-        //This part allows for the custom selection label preview
+        //This part allows for the custom field selection to be visible in the label preview
         $data = explode(';', Setting::getSettings()->label2_fields);
         $data = array_map(function($element) {
             $a = explode('=', $element);
@@ -74,12 +74,15 @@ class LabelsController extends Controller
             $exampleAsset->model->category->id = 999999;
             $exampleAsset->model->category->name = trans('admin/labels/table.example_category');
         }
-
-        foreach($data as $innerArray){
-            foreach($innerArray as $key => $value) {
-                $exampleAsset->{$value} = "{{$key}}";
-            }
+        //turns a multidimensional array in an associative array for no double for looping
+        $result = array();
+        foreach ($data as $entry) {
+            $result[key($entry)] = reset($entry);
         }
+        foreach($result as $key => $value) {
+            $exampleAsset->{$value} = "{{$key}}";
+        }
+
 
         $settings = Setting::getSettings();
         if (request()->has('settings')) {