From f7bbec6be49c21c0319ab9046fb3e6450ac64281 Mon Sep 17 00:00:00 2001 From: "steve@degga.net" Date: Sun, 31 Mar 2024 22:18:44 -0400 Subject: [PATCH 001/260] Makes all manufacturer URLs dynamic, not just warranty lookup. --- app/Models/Manufacturer.php | 4 ++-- app/Presenters/AssetPresenter.php | 7 +++---- resources/views/hardware/view.blade.php | 20 ++++++++++---------- 3 files changed, 15 insertions(+), 16 deletions(-) diff --git a/app/Models/Manufacturer.php b/app/Models/Manufacturer.php index 5408d50c36..85907f7ddb 100755 --- a/app/Models/Manufacturer.php +++ b/app/Models/Manufacturer.php @@ -22,9 +22,9 @@ class Manufacturer extends SnipeModel // Declare the rules for the form validation protected $rules = [ 'name' => 'required|min:2|max:255|unique:manufacturers,name,NULL,id,deleted_at,NULL', - 'url' => 'url|nullable', + 'url' => 'nullable|starts_with:http://,https://,afp://,facetime://,file://,irc://', 'support_email' => 'email|nullable', - 'support_url' => 'nullable|url', + 'support_url' => 'nullable|starts_with:http://,https://,afp://,facetime://,file://,irc://', 'warranty_lookup_url' => 'nullable|starts_with:http://,https://,afp://,facetime://,file://,irc://' ]; diff --git a/app/Presenters/AssetPresenter.php b/app/Presenters/AssetPresenter.php index 163ee1b606..16bb384176 100644 --- a/app/Presenters/AssetPresenter.php +++ b/app/Presenters/AssetPresenter.php @@ -556,13 +556,12 @@ class AssetPresenter extends Presenter } /** - * Used to take user created warranty URL and dynamically fill in the needed values per asset + * Used to take user created URL and dynamically fill in the needed values per asset * @return string */ - public function dynamicWarrantyUrl() + public function dynamicWarrantyUrl($dynamic_url) { - $warranty_lookup_url = $this->model->model->manufacturer->warranty_lookup_url; - $url = (str_replace('{LOCALE}',\App\Models\Setting::getSettings()->locale, $warranty_lookup_url)); + $url = (str_replace('{LOCALE}',\App\Models\Setting::getSettings()->locale, $dynamic_url)); $url = (str_replace('{SERIAL}', urlencode($this->model->serial), $url)); $url = (str_replace('{MODEL_NAME}', urlencode($this->model->model->name), $url)); $url = (str_replace('{MODEL_NUMBER}', urlencode($this->model->model->model_number), $url)); diff --git a/resources/views/hardware/view.blade.php b/resources/views/hardware/view.blade.php index 461f2a4688..570cf2745a 100755 --- a/resources/views/hardware/view.blade.php +++ b/resources/views/hardware/view.blade.php @@ -281,22 +281,22 @@
  • {{ $asset->model->manufacturer->name }}
  • @endcan - @if (($asset->model) && ($asset->model->manufacturer->url)) + @if (($asset->model->manufacturer) && ($asset->model->manufacturer->url!=''))
  • - - {{ $asset->model->manufacturer->url }} - + + {{ $asset->present()->dynamicUrl($asset->model->manufacturer->url) }} +
  • @endif - @if (($asset->model) && ($asset->model->manufacturer->support_url)) + @if (($asset->model->manufacturer) && ($asset->model->manufacturer->support_url!=''))
  • - - {{ $asset->model->manufacturer->support_url }} - + + {{$asset>present()>dynamicUrl($asset>model>manufacturer->support_url) }} +
  • @endif @@ -304,8 +304,8 @@ @if (($asset->model->manufacturer) && ($asset->model->manufacturer->warranty_lookup_url!=''))
  • - - {{ $asset->present()->dynamicWarrantyUrl() }} + + {{ $asset->present()->dynamicUrl($asset->model->manufacturer->warranty_lookup_url) }}
  • From 83ce04dc8dbcd6b9e137514e0d926da2dbfa93d2 Mon Sep 17 00:00:00 2001 From: "steve@degga.net" Date: Sun, 31 Mar 2024 22:31:06 -0400 Subject: [PATCH 002/260] Fixes syntax error. --- resources/views/hardware/view.blade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/views/hardware/view.blade.php b/resources/views/hardware/view.blade.php index 570cf2745a..9100787dcd 100755 --- a/resources/views/hardware/view.blade.php +++ b/resources/views/hardware/view.blade.php @@ -295,7 +295,7 @@
  • - {{$asset>present()>dynamicUrl($asset>model>manufacturer->support_url) }} + {{ $asset->present()->dynamicUrl($asset->model->manufacturer->support_url) }}
  • From bf10fd0cf03489168d919e5c48284588234710cb Mon Sep 17 00:00:00 2001 From: "steve@degga.net" Date: Sun, 31 Mar 2024 22:37:41 -0400 Subject: [PATCH 003/260] Rename dynamicUrl() method --- app/Presenters/AssetPresenter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Presenters/AssetPresenter.php b/app/Presenters/AssetPresenter.php index 16bb384176..b86135f33b 100644 --- a/app/Presenters/AssetPresenter.php +++ b/app/Presenters/AssetPresenter.php @@ -559,7 +559,7 @@ class AssetPresenter extends Presenter * Used to take user created URL and dynamically fill in the needed values per asset * @return string */ - public function dynamicWarrantyUrl($dynamic_url) + public function dynamicUrl($dynamic_url) { $url = (str_replace('{LOCALE}',\App\Models\Setting::getSettings()->locale, $dynamic_url)); $url = (str_replace('{SERIAL}', urlencode($this->model->serial), $url)); From 3e564eaf192d4d9417bdac61acdd37db4e23cf05 Mon Sep 17 00:00:00 2001 From: "steve@degga.net" Date: Wed, 3 Apr 2024 20:09:37 -0400 Subject: [PATCH 004/260] fixed accidentally forgot update a call to the old dynamicWarrantyUrl() method in hardware/view.blade.php --- resources/views/hardware/view.blade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/views/hardware/view.blade.php b/resources/views/hardware/view.blade.php index 9100787dcd..10be0f4b34 100755 --- a/resources/views/hardware/view.blade.php +++ b/resources/views/hardware/view.blade.php @@ -575,7 +575,7 @@ {{ trans('admin/hardware/form.months') }} @if (($asset->model) && ($asset->model->manufacturer) && ($asset->model->manufacturer->warranty_lookup_url!='')) - + @endif From 3fcc06748125bdc3d0ea99a4944885453807aff0 Mon Sep 17 00:00:00 2001 From: "steve@degga.net" Date: Thu, 4 Apr 2024 10:27:44 -0400 Subject: [PATCH 005/260] Removes accidental changes on two lines --- resources/views/hardware/view.blade.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/views/hardware/view.blade.php b/resources/views/hardware/view.blade.php index 10be0f4b34..ec7d909aa0 100755 --- a/resources/views/hardware/view.blade.php +++ b/resources/views/hardware/view.blade.php @@ -286,7 +286,7 @@ {{ $asset->present()->dynamicUrl($asset->model->manufacturer->url) }} - +