diff --git a/app/Http/Controllers/Licenses/LicenseCheckoutController.php b/app/Http/Controllers/Licenses/LicenseCheckoutController.php index 5db8bb17d7..db378b8f0f 100644 --- a/app/Http/Controllers/Licenses/LicenseCheckoutController.php +++ b/app/Http/Controllers/Licenses/LicenseCheckoutController.php @@ -40,7 +40,7 @@ class LicenseCheckoutController extends Controller } // Make sure the license is expired or terminated - if ($license->isInactive()){ + if ($license->isInactive()) { return redirect()->route('licenses.index')->with('error', trans('admin/licenses/message.checkout.license_is_inactive')); } @@ -130,7 +130,7 @@ class LicenseCheckoutController extends Controller throw new \Illuminate\Http\Exceptions\HttpResponseException(redirect()->route('licenses.index')->with('error', trans('admin/licenses/message.checkout.not_enough_seats'))); } - + if (! $licenseSeat->license->is($license)) { throw new \Illuminate\Http\Exceptions\HttpResponseException(redirect()->route('licenses.index')->with('error', trans('admin/licenses/message.checkout.mismatch'))); } diff --git a/app/Models/License.php b/app/Models/License.php index 3edc7a10a9..855995b43c 100755 --- a/app/Models/License.php +++ b/app/Models/License.php @@ -307,7 +307,26 @@ class License extends Depreciable $terminated = $this->termination_date && $this->asDateTime($this->termination_date)->startofDay()->lessThanOrEqualTo($day); - return $expired || $terminated; + return $this->isExpired() || $this->isTerminated(); + } + + public function isExpired(): bool + { + $day = now()->startOfDay(); + + $expired = $this->expiration_date && $this->asDateTime($this->expiration_date)->startofDay()->lessThanOrEqualTo($day); + + return $expired; + } + + public function isTerminated(): bool + { + $day = now()->startOfDay(); + + $terminated = $this->termination_date && $this->asDateTime($this->termination_date)->startofDay()->lessThanOrEqualTo($day); + + + return $terminated; } /** diff --git a/resources/views/licenses/view.blade.php b/resources/views/licenses/view.blade.php index 591870c544..43d2c697c0 100755 --- a/resources/views/licenses/view.blade.php +++ b/resources/views/licenses/view.blade.php @@ -249,6 +249,11 @@