From 7e89b58746d5e18863fb2097fd6727aabaeeb04c Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Tue, 16 Jul 2024 16:08:42 -0700 Subject: [PATCH] Move files to computed property --- app/Livewire/Importer.php | 12 +++++++++--- resources/views/livewire/importer.blade.php | 2 +- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/app/Livewire/Importer.php b/app/Livewire/Importer.php index 4c89e63dc2..ccd621440b 100644 --- a/app/Livewire/Importer.php +++ b/app/Livewire/Importer.php @@ -5,12 +5,11 @@ namespace App\Livewire; use App\Models\CustomField; use App\Models\Import; use Illuminate\Support\Facades\Storage; +use Livewire\Attributes\Computed; use Livewire\Component; class Importer extends Component { - public $files; - public $progress = -1; //upload progress - '-1' means don't show public $progress_message; public $progress_bar_class = 'progress-bar-warning'; @@ -545,6 +544,8 @@ class Importer extends Component } } } + + unset($this->files); } public function clearMessage() @@ -553,9 +554,14 @@ class Importer extends Component $this->message_type = null; } + #[Computed] + public function files() + { + return Import::orderBy('id', 'desc')->get(); + } + public function render() { - $this->files = Import::orderBy('id','desc')->get(); //HACK - slows down renders. return view('livewire.importer') ->extends('layouts.default') ->section('content'); diff --git a/resources/views/livewire/importer.blade.php b/resources/views/livewire/importer.blade.php index 53bb59ffaf..c85a6ea9d5 100644 --- a/resources/views/livewire/importer.blade.php +++ b/resources/views/livewire/importer.blade.php @@ -118,7 +118,7 @@ - @foreach($files as $currentFile) + @foreach($this->files as $currentFile) {{ $currentFile->file_path }}