Fix FIXME's by downgrading them to TODO's :)

This commit is contained in:
Brady Wetherington
2021-11-10 11:37:10 -08:00
parent 91f087258b
commit 864cc4f8d5
3 changed files with 27 additions and 33 deletions
@@ -145,7 +145,7 @@ class LoginController extends Controller
}
// Check if the user already exists in the database and was imported via LDAP
$user = User::where('username', '=', $request->input('username'))->whereNull('deleted_at')->where('ldap_import', '=', 1)->where('activated', '=', '1')->first(); // FIXME - if we get more than one we should fail.
$user = User::where('username', '=', $request->input('username'))->whereNull('deleted_at')->where('ldap_import', '=', 1)->where('activated', '=', '1')->first(); // FIXME - if we get more than one we should fail. and we sure about this ldap_import thing?
Log::debug("Local auth lookup complete");
// The user does not exist in the database. Try to get them from LDAP.
@@ -175,7 +175,7 @@ class LoginController extends Controller
$user->last_name = $ldap_attr['lastname']; //FIXME (or TODO?) - do we need to map additional fields that we now support? E.g. country, phone, etc.
$user->save();
} // End if(!user)
return $user;
return $user;
}
private function loginViaRemoteUser(Request $request)