diff --git a/app/Http/Controllers/ReportsController.php b/app/Http/Controllers/ReportsController.php index de72206c77..36065cda5d 100644 --- a/app/Http/Controllers/ReportsController.php +++ b/app/Http/Controllers/ReportsController.php @@ -338,34 +338,12 @@ class ReportsController extends Controller $rows = array(); foreach ($activitylogs as $activity) { - // This is janky AF and should be handled better. - if ($activity->itemType() == "asset") { - $routename = 'assets'; - $activity_icons = ''; - } elseif ($activity->itemType() == "accessory") { - $routename = 'accessories'; - $activity_icons = ''; - } elseif ($activity->itemType()=="consumable") { - $routename = 'consumables'; - $activity_icons = ''; - } elseif ($activity->itemType()=="license"){ - $routename = 'licenses'; - $activity_icons = ''; - } elseif ($activity->itemType()=="component") { - $routename = 'components'; - $activity_icons = ''; - } else { - $activity_icons = ''; - } - - if (($activity->item) && ($activity->itemType()=="asset")) { $activity_item = ''.e($activity->item->asset_tag).' - '. e($activity->item->showAssetName()).''; $item_type = 'asset'; } elseif ($activity->item) { - $activity_item = '' . e($activity->item->name) . ''; + $activity_item = '' . e($activity->item->name) . ''; $item_type = $activity->itemType(); - } else { $activity_item = "unkonwn"; $item_type = "null"; @@ -373,7 +351,7 @@ class ReportsController extends Controller if (($activity->user) && ($activity->action_type=="uploaded") && ($activity->itemType()=="user")) { - $activity_target = ''.$activity->user->fullName().''; + $activity_target = ''.$activity->user->fullName().''; } elseif ($activity->target_type === "App\Models\Asset") { if($activity->target) { $activity_target = ''.$activity->target->showAssetName().''; @@ -382,16 +360,16 @@ class ReportsController extends Controller } } elseif ( $activity->target_type === "App\Models\User") { if($activity->target) { - $activity_target = ''.$activity->target->fullName().''; + $activity_target = ''.$activity->target->fullName().''; } else { $activity_target = ''; } } elseif (($activity->action_type=='accepted') || ($activity->action_type=='declined')) { - $activity_target = '' . e($activity->item->assigneduser->fullName()) . ''; + $activity_target = '' . e($activity->item->assigneduser->fullName()) . ''; } elseif ($activity->action_type=='requested') { if ($activity->user) { - $activity_target = ''.$activity->user->fullName().''; + $activity_target = ''.$activity->user->fullName().''; } else { $activity_target = ''; } @@ -405,7 +383,7 @@ class ReportsController extends Controller $rows[] = array( - 'icon' => $activity_icons, + 'icon' => '', 'created_at' => date("M d, Y g:iA", strtotime($activity->created_at)), 'action_type' => strtolower(trans('general.'.str_replace(' ','_',$activity->action_type))), 'admin' => $activity->user ? (string) link_to('/admin/users/'.$activity->user_id.'/view', $activity->user->fullName()) : '', diff --git a/app/Http/Controllers/UsersController.php b/app/Http/Controllers/UsersController.php index 68c1263017..b3e2bc372b 100755 --- a/app/Http/Controllers/UsersController.php +++ b/app/Http/Controllers/UsersController.php @@ -57,7 +57,7 @@ class UsersController extends Controller * @since [v1.0] * @return View */ - public function getIndex() + public function index() { return View::make('users/index'); } @@ -69,7 +69,7 @@ class UsersController extends Controller * @since [v1.0] * @return View */ - public function getCreate() + public function create() { $groups = Group::pluck('name', 'id'); @@ -102,7 +102,7 @@ class UsersController extends Controller * @since [v1.0] * @return Redirect */ - public function postCreate(SaveUserRequest $request) + public function store(SaveUserRequest $request) { $user = new User; @@ -189,7 +189,7 @@ class UsersController extends Controller * @since [v1.8] * @return string JSON */ - public function store() + public function apiStore() { $user = new User; @@ -255,7 +255,7 @@ class UsersController extends Controller return $output; } - public function getEdit($id = null) + public function edit($id = null) { try { // Get the user information @@ -263,7 +263,7 @@ class UsersController extends Controller $permissions = config('permissions'); if (!Company::isCurrentUserHasAccess($user)) { - return redirect()->route('users')->with('error', trans('general.insufficient_permissions')); + return redirect()->route('users.index')->with('error', trans('general.insufficient_permissions')); } $groups = Group::pluck('name', 'id'); @@ -280,7 +280,7 @@ class UsersController extends Controller $error = trans('admin/users/message.user_not_found', compact('id')); // Redirect to the user management page - return redirect()->route('users')->with('error', $error); + return redirect()->route('users.index')->with('error', $error); } // Show the page @@ -298,7 +298,7 @@ class UsersController extends Controller * @param int $id * @return Redirect */ - public function postEdit(UpdateUserRequest $request, $id = null) + public function update(UpdateUserRequest $request, $id = null) { // We need to reverse the UI specific logic for our // permissions here before we update the user. @@ -306,7 +306,7 @@ class UsersController extends Controller app('request')->request->set('permissions', $permissions); // Only update the email address if locking is set to false if (config('app.lock_passwords')) { - return redirect()->route('users')->with('error', 'Denied! You cannot update user information on the demo.'); + return redirect()->route('users.index')->with('error', 'Denied! You cannot update user information on the demo.'); } try { @@ -328,12 +328,12 @@ class UsersController extends Controller if (!Company::isCurrentUserHasAccess($user)) { - return redirect()->route('users')->with('error', trans('general.insufficient_permissions')); + return redirect()->route('users.index')->with('error', trans('general.insufficient_permissions')); } - + } catch (UserNotFoundException $e) { $error = trans('admin/users/message.user_not_found', compact('id')); - return redirect()->route('users')->with('error', $error); + return redirect()->route('users.index')->with('error', $error); } @@ -402,7 +402,7 @@ class UsersController extends Controller $success = trans('admin/users/message.success.update'); // Redirect to the user page - return redirect()->route('users')->with('success', $success); + return redirect()->route('users.index')->with('success', $success); } return redirect()->back()->withInput()->withErrors($user->getErrors()); @@ -417,7 +417,7 @@ class UsersController extends Controller * @param int $id * @return Redirect */ - public function getDelete($id = null) + public function destroy($id = null) { try { // Get user information @@ -429,32 +429,32 @@ class UsersController extends Controller $error = trans('admin/users/message.error.delete'); // Redirect to the user management page - return redirect()->route('users')->with('error', $error); + return redirect()->route('users.index')->with('error', $error); } // Do we have permission to delete this user? if ((!Auth::user()->isSuperUser()) || (config('app.lock_passwords'))) { // Redirect to the user management page - return redirect()->route('users')->with('error', 'Insufficient permissions!'); + return redirect()->route('users.index')->with('error', 'Insufficient permissions!'); } if (count($user->assets) > 0) { // Redirect to the user management page - return redirect()->route('users')->with('error', 'This user still has ' . count($user->assets) . ' assets associated with them.'); + return redirect()->route('users.index')->with('error', 'This user still has ' . count($user->assets) . ' assets associated with them.'); } if (count($user->licenses) > 0) { // Redirect to the user management page - return redirect()->route('users')->with('error', 'This user still has ' . count($user->licenses) . ' licenses associated with them.'); + return redirect()->route('users.index')->with('error', 'This user still has ' . count($user->licenses) . ' licenses associated with them.'); } if (count($user->accessories) > 0) { // Redirect to the user management page - return redirect()->route('users')->with('error', 'This user still has ' . count($user->accessories) . ' accessories associated with them.'); + return redirect()->route('users.index')->with('error', 'This user still has ' . count($user->accessories) . ' accessories associated with them.'); } // Delete the user @@ -464,13 +464,13 @@ class UsersController extends Controller $success = trans('admin/users/message.success.delete'); // Redirect to the user management page - return redirect()->route('users')->with('success', $success); + return redirect()->route('users.index')->with('success', $success); } catch (UserNotFoundException $e) { // Prepare the error message $error = trans('admin/users/message.user_not_found', compact('id')); // Redirect to the user management page - return redirect()->route('users')->with('error', $error); + return redirect()->route('users.index')->with('error', $error); } } @@ -513,7 +513,7 @@ class UsersController extends Controller if ((!Input::has('edit_user')) || (count(Input::has('edit_user')) == 0)) { return redirect()->back()->with('error', 'No users selected'); } elseif ((!Input::has('status_id')) || (count(Input::has('status_id')) == 0)) { - return redirect()->route('users')->with('error', 'No status selected'); + return redirect()->route('users.index')->with('error', 'No status selected'); } else { $user_raw_array = Input::get('edit_user'); @@ -524,7 +524,7 @@ class UsersController extends Controller } if (!Auth::user()->isSuperUser()) { - return redirect()->route('users')->with('error', trans('admin/users/message.insufficient_permissions')); + return redirect()->route('users.index')->with('error', trans('admin/users/message.insufficient_permissions')); } if (!config('app.lock_passwords')) { @@ -595,12 +595,9 @@ class UsersController extends Controller $user->delete(); } - - - - return redirect()->route('users')->with('success', 'Your selected users have been deleted and their assets have been updated.'); + return redirect()->route('users.index')->with('success', 'Your selected users have been deleted and their assets have been updated.'); } else { - return redirect()->route('users')->with('error', 'Bulk delete is not enabled in this installation'); + return redirect()->route('users.index')->with('error', 'Bulk delete is not enabled in this installation'); } } @@ -619,18 +616,18 @@ class UsersController extends Controller // Get user information if (!$user = User::onlyTrashed()->find($id)) { - return redirect()->route('users')->with('error', trans('admin/users/messages.user_not_found')); + return redirect()->route('users.index')->with('error', trans('admin/users/messages.user_not_found')); } if (!Company::isCurrentUserHasAccess($user)) { - return redirect()->route('users')->with('error', trans('general.insufficient_permissions')); + return redirect()->route('users.index')->with('error', trans('general.insufficient_permissions')); } else { // Restore the user if (User::withTrashed()->where('id', $id)->restore()) { - return redirect()->route('users')->with('success', trans('admin/users/message.success.restored')); + return redirect()->route('users.index')->with('success', trans('admin/users/message.success.restored')); } else { - return redirect()->route('users')->with('error', 'User could not be restored.'); + return redirect()->route('users.index')->with('error', 'User could not be restored.'); } } @@ -645,7 +642,7 @@ class UsersController extends Controller * @param int $userId * @return View */ - public function getView($userId = null) + public function show($userId = null) { $user = User::with('assets', 'assets.model', 'consumables', 'accessories', 'licenses', 'userloc')->withTrashed()->find($userId); @@ -655,7 +652,7 @@ class UsersController extends Controller if (isset($user->id)) { if (!Company::isCurrentUserHasAccess($user)) { - return redirect()->route('users')->with('error', trans('general.insufficient_permissions')); + return redirect()->route('users.index')->with('error', trans('general.insufficient_permissions')); } else { return View::make('users/view', compact('user', 'userlog')); } @@ -664,7 +661,7 @@ class UsersController extends Controller $error = trans('admin/users/message.user_not_found', compact('id')); // Redirect to the user management page - return redirect()->route('users')->with('error', $error); + return redirect()->route('users.index')->with('error', $error); } } @@ -688,26 +685,26 @@ class UsersController extends Controller $error = trans('admin/users/message.error.unsuspend'); // Redirect to the user management page - return redirect()->route('users')->with('error', $error); + return redirect()->route('users.index')->with('error', $error); } // Do we have permission to unsuspend this user? if ($user->isSuperUser() && !Auth::user()->isSuperUser()) { // Redirect to the user management page - return redirect()->route('users')->with('error', 'Insufficient permissions!'); + return redirect()->route('users.index')->with('error', 'Insufficient permissions!'); } // Prepare the success message $success = trans('admin/users/message.success.unsuspend'); // Redirect to the user management page - return redirect()->route('users')->with('success', $success); + return redirect()->route('users.index')->with('success', $success); } catch (UserNotFoundException $e) { // Prepare the error message $error = trans('admin/users/message.user_not_found', compact('id')); // Redirect to the user management page - return redirect()->route('users')->with('error', $error); + return redirect()->route('users.index')->with('error', $error); } } @@ -771,7 +768,7 @@ class UsersController extends Controller $error = trans('admin/users/message.user_not_found', compact('id')); // Redirect to the user management page - return redirect()->route('users')->with('error', $error); + return redirect()->route('users.index')->with('error', $error); } } @@ -896,7 +893,7 @@ class UsersController extends Controller }); - return redirect()->route('users')->with('duplicates', $duplicates)->with('success', 'Success'); + return redirect()->route('users.index')->with('duplicates', $duplicates)->with('success', 'Success'); } /** @@ -992,7 +989,7 @@ class UsersController extends Controller } } if (Gate::allows('users.edit')) { - $actions .= 'id) . '" class="btn btn-warning btn-sm"> '; $actions .= ' '; } else { $actions .= ' '; @@ -1015,7 +1012,7 @@ class UsersController extends Controller $rows[] = array( 'id' => $user->id, 'checkbox' => ($status!='deleted') ? '' : '', - 'name' => ''.e($user->fullName()).'', + 'name' => (string)link_to_route('users.show', e($user->fullName()), ['user' => $user->id]), 'jobtitle' => e($user->jobtitle), 'email' => ($user->email!='') ? '' @@ -1062,7 +1059,7 @@ class UsersController extends Controller if (isset($user->id)) { if (!Company::isCurrentUserHasAccess($user)) { - return redirect()->route('users')->with('error', trans('general.insufficient_permissions')); + return redirect()->route('users.index')->with('error', trans('general.insufficient_permissions')); } foreach (Input::file('file') as $file) { @@ -1111,7 +1108,7 @@ class UsersController extends Controller if (isset($user->id)) { if (!Company::isCurrentUserHasAccess($user)) { - return redirect()->route('users')->with('error', trans('general.insufficient_permissions')); + return redirect()->route('users.index')->with('error', trans('general.insufficient_permissions')); } else { $log = Actionlog::find($fileId); $full_filename = $destinationPath . '/' . $log->filename; @@ -1126,7 +1123,7 @@ class UsersController extends Controller $error = trans('admin/users/message.does_not_exist', compact('id')); // Redirect to the licence management page - return redirect()->route('users')->with('error', $error); + return redirect()->route('users.index')->with('error', $error); } } @@ -1147,7 +1144,7 @@ class UsersController extends Controller // the license is valid if (isset($user->id)) { if (!Company::isCurrentUserHasAccess($user)) { - return redirect()->route('users')->with('error', trans('general.insufficient_permissions')); + return redirect()->route('users.index')->with('error', trans('general.insufficient_permissions')); } else { $log = Actionlog::find($fileId); $file = $log->get_src('users'); @@ -1158,7 +1155,7 @@ class UsersController extends Controller $error = trans('admin/users/message.does_not_exist', compact('id')); // Redirect to the licence management page - return redirect()->route('users')->with('error', $error); + return redirect()->route('users.index')->with('error', $error); } } @@ -1177,14 +1174,14 @@ class UsersController extends Controller try { $ldapconn = Ldap::connectToLdap(); } catch (\Exception $e) { - return redirect()->route('users')->with('error',$e->getMessage()); + return redirect()->route('users.index')->with('error',$e->getMessage()); } try { Ldap::bindAdminToLdap($ldapconn); } catch (\Exception $e) { - return redirect()->route('users')->with('error',$e->getMessage()); + return redirect()->route('users.index')->with('error',$e->getMessage()); } return View::make('users/ldap') @@ -1358,7 +1355,7 @@ class UsersController extends Controller trans('admin/users/table.activated'), trans('general.created_at') ]; - + fputcsv($handle, $headers); foreach ($users as $user) { diff --git a/app/Models/Actionlog.php b/app/Models/Actionlog.php index db3556c97f..41a64b8ad4 100755 --- a/app/Models/Actionlog.php +++ b/app/Models/Actionlog.php @@ -58,6 +58,43 @@ class Actionlog extends Model return camel_case(class_basename($this->item_type)); } + public function parseItemRoute() { + if ($this->itemType() == "asset") { + $itemroute = 'assets'; + } elseif ($this->itemType() == "accessory") { + $itemroute = 'accessories'; + } elseif ($this->itemType()=="consumable") { + $itemroute = 'consumables'; + } elseif ($this->itemType()=="license"){ + $itemroute = 'licenses'; + } elseif ($this->itemType()=="component") { + $itemroute = 'components'; + } else { + $itemroute = ''; + } + + return $itemroute; + } + + + public function parseItemIcon() { + if ($this->itemType() == "asset") { + $itemicon = 'fa fa-barcode'; + } elseif ($this->itemType() == "accessory") { + $itemicon = 'fa fa-keyboard-o'; + } elseif ($this->itemType()=="consumable") { + $itemicon = 'fa fa-tint'; + } elseif ($this->itemType()=="license"){ + $itemicon = 'fa fa-floppy-o'; + } elseif ($this->itemType()=="component") { + $itemicon = 'fa fa-hdd-o'; + } else { + $itemicon = 'fa fa-paperclip'; + } + + return $itemicon; + } + public function uploads() { return $this->morphTo('item') diff --git a/app/Providers/RouteServiceProvider.php b/app/Providers/RouteServiceProvider.php index 5da762382e..054a0f9232 100644 --- a/app/Providers/RouteServiceProvider.php +++ b/app/Providers/RouteServiceProvider.php @@ -62,6 +62,7 @@ class RouteServiceProvider extends ServiceProvider require base_path('routes/web/consumables.php'); require base_path('routes/web/fields.php'); require base_path('routes/web/components.php'); + require base_path('routes/web/users.php'); require base_path('routes/web.php'); }); } diff --git a/config/version.php b/config/version.php index 32862b5197..b00ccabf25 100644 --- a/config/version.php +++ b/config/version.php @@ -2,6 +2,6 @@ return array ( 'app_version' => 'v3.6.1', 'build_version' => 'pre', - 'hash_version' => '90', - 'full_hash' => 'v3.6.1-pre-90-ge685e0f', + 'hash_version' => '92', + 'full_hash' => 'v3.6.1-pre-92-g4751bcd', ); \ No newline at end of file diff --git a/resources/views/groups/view.blade.php b/resources/views/groups/view.blade.php index a2b68561b8..d42c622fce 100644 --- a/resources/views/groups/view.blade.php +++ b/resources/views/groups/view.blade.php @@ -33,7 +33,7 @@ @foreach ($users as $user) - {{ $user->first_name }} {{ $user->last_name }} + {{ $user->first_name }} {{ $user->last_name }} @endforeach diff --git a/resources/views/hardware/qr-view.blade.php b/resources/views/hardware/qr-view.blade.php index 92f16e8428..6c67a28ea5 100644 --- a/resources/views/hardware/qr-view.blade.php +++ b/resources/views/hardware/qr-view.blade.php @@ -281,7 +281,7 @@ @if ((isset($log->target_id)) && ($log->target_id!=0) && ($log->target_id!='')) @if ($log->target->deleted_at=='') - + {{ $log->user->fullName() }} @else @@ -346,7 +346,7 @@