From adfb8895dfa630be9ff79d2a1a374b592094bbfc Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Mon, 12 Feb 2024 16:31:32 -0800 Subject: [PATCH] Improve factory state name --- database/factories/AccessoryFactory.php | 2 +- tests/Feature/Checkins/AccessoryCheckinTest.php | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/database/factories/AccessoryFactory.php b/database/factories/AccessoryFactory.php index b7c834b997..ce0d60cc18 100644 --- a/database/factories/AccessoryFactory.php +++ b/database/factories/AccessoryFactory.php @@ -142,7 +142,7 @@ class AccessoryFactory extends Factory }); } - public function checkedOut(User $user = null) + public function checkedOutToUser(User $user = null) { return $this->afterCreating(function (Accessory $accessory) use ($user) { $accessory->users()->attach($accessory->id, [ diff --git a/tests/Feature/Checkins/AccessoryCheckinTest.php b/tests/Feature/Checkins/AccessoryCheckinTest.php index c312c0da83..0e889e9fff 100644 --- a/tests/Feature/Checkins/AccessoryCheckinTest.php +++ b/tests/Feature/Checkins/AccessoryCheckinTest.php @@ -19,7 +19,7 @@ class AccessoryCheckinTest extends TestCase public function testCheckingInAccessoryRequiresCorrectPermission() { $this->actingAs(User::factory()->create()) - ->post(route('accessories.checkin.store', Accessory::factory()->checkedOut()->create())) + ->post(route('accessories.checkin.store', Accessory::factory()->checkedOutToUser()->create())) ->assertForbidden(); } @@ -28,7 +28,7 @@ class AccessoryCheckinTest extends TestCase Event::fake([CheckoutableCheckedIn::class]); $user = User::factory()->create(); - $accessory = Accessory::factory()->checkedOut($user)->create(); + $accessory = Accessory::factory()->checkedOutToUser($user)->create(); $this->assertTrue($accessory->users->contains($user)); @@ -45,7 +45,7 @@ class AccessoryCheckinTest extends TestCase Notification::fake(); $user = User::factory()->create(); - $accessory = Accessory::factory()->checkedOut($user)->create(); + $accessory = Accessory::factory()->checkedOutToUser($user)->create(); $accessory->category->update(['checkin_email' => true]); @@ -69,7 +69,7 @@ class AccessoryCheckinTest extends TestCase Notification::fake(); $user = User::factory()->create(); - $accessory = Accessory::factory()->checkedOut($user)->create(); + $accessory = Accessory::factory()->checkedOutToUser($user)->create(); $accessory->category->update(['checkin_email' => false]);