From b331bb33d95009fa9205237e6d926b17401e1833 Mon Sep 17 00:00:00 2001
From: snipe <snipe@snipe.net>
Date: Mon, 20 Sep 2021 15:37:24 -0700
Subject: [PATCH] Code fixes and a new migration

Signed-off-by: snipe <snipe@snipe.net>
---
 .../Api/StatuslabelsController.php            |  6 +--
 ...45619_add_show_in_nav_to_status_labels.php |  2 +-
 ...54937_add_default_flag_on_statuslabels.php |  2 +-
 ...83216_change_default_label_to_nullable.php | 38 +++++++++++++++++++
 4 files changed, 43 insertions(+), 5 deletions(-)
 create mode 100644 database/migrations/2021_09_20_183216_change_default_label_to_nullable.php

diff --git a/app/Http/Controllers/Api/StatuslabelsController.php b/app/Http/Controllers/Api/StatuslabelsController.php
index 534c49a568..89bc73f4b5 100644
--- a/app/Http/Controllers/Api/StatuslabelsController.php
+++ b/app/Http/Controllers/Api/StatuslabelsController.php
@@ -73,7 +73,7 @@ class StatuslabelsController extends Controller
         $statuslabel->archived          =  $statusType['archived'];
         $statuslabel->color             =  $request->input('color');
         $statuslabel->show_in_nav       =  $request->input('show_in_nav', 0);
-        $statuslabel->default_label     =  $request->input('default_label');
+        $statuslabel->default_label     =  $request->input('default_label', 0);
 
 
         if ($statuslabel->save()) {
@@ -124,8 +124,8 @@ class StatuslabelsController extends Controller
         $statuslabel->pending           =  $statusType['pending'];
         $statuslabel->archived          =  $statusType['archived'];
         $statuslabel->color             =  $request->input('color');
-        $statuslabel->show_in_nav       =  $request->input('show_in_nav');
-        $statuslabel->default_label     =  $request->input('default_label');
+        $statuslabel->show_in_nav       =  $request->input('show_in_nav', 0);
+        $statuslabel->default_label     =  $request->input('default_label', 0);
 
         if ($statuslabel->save()) {
             return response()->json(Helper::formatStandardApiResponse('success', $statuslabel, trans('admin/statuslabels/message.update.success')));
diff --git a/database/migrations/2016_08_23_145619_add_show_in_nav_to_status_labels.php b/database/migrations/2016_08_23_145619_add_show_in_nav_to_status_labels.php
index a67f34db59..1dde84e813 100644
--- a/database/migrations/2016_08_23_145619_add_show_in_nav_to_status_labels.php
+++ b/database/migrations/2016_08_23_145619_add_show_in_nav_to_status_labels.php
@@ -13,7 +13,7 @@ class AddShowInNavToStatusLabels extends Migration
     public function up()
     {
         Schema::table('status_labels', function (Blueprint $table) {
-            $table->boolean('show_in_nav')->default(0);
+            $table->boolean('show_in_nav')->nullable()->default(0);
         });
     }
 
diff --git a/database/migrations/2018_03_06_054937_add_default_flag_on_statuslabels.php b/database/migrations/2018_03_06_054937_add_default_flag_on_statuslabels.php
index 54a62bd770..ebbe372733 100644
--- a/database/migrations/2018_03_06_054937_add_default_flag_on_statuslabels.php
+++ b/database/migrations/2018_03_06_054937_add_default_flag_on_statuslabels.php
@@ -14,7 +14,7 @@ class AddDefaultFlagOnStatuslabels extends Migration
     public function up()
     {
         Schema::table('status_labels', function (Blueprint $table) {
-            $table->boolean('default_label')->default(0);
+            $table->boolean('default_label')->nullable()->default(0);
         });
     }
 
diff --git a/database/migrations/2021_09_20_183216_change_default_label_to_nullable.php b/database/migrations/2021_09_20_183216_change_default_label_to_nullable.php
new file mode 100644
index 0000000000..6a3ce03dea
--- /dev/null
+++ b/database/migrations/2021_09_20_183216_change_default_label_to_nullable.php
@@ -0,0 +1,38 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+class ChangeDefaultLabelToNullable extends Migration
+{
+    /**
+     * Run the migrations.
+     * 
+     * This is stupid because it has a default valuye of 0 so it *should* 
+     * default to 0, but it doesn't on some versions of MySQL. 
+     *
+     * @return void
+     */
+    public function up()
+    {
+        Schema::table('nullable', function (Blueprint $table) {
+            Schema::table('status_labels', function (Blueprint $table) {
+                $table->boolean('default_label')->nullable()->default(0);
+                $table->boolean('show_in_nav')->nullable()->default(0);
+            });
+        });
+    }
+
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down()
+    {
+        Schema::table('nullable', function (Blueprint $table) {
+            //
+        });
+    }
+}