diff --git a/app/Http/Controllers/ReportsController.php b/app/Http/Controllers/ReportsController.php index a024b17042..ef896fa9f5 100644 --- a/app/Http/Controllers/ReportsController.php +++ b/app/Http/Controllers/ReportsController.php @@ -367,14 +367,30 @@ class ReportsController extends Controller if (($activity->user) && ($activity->action_type=="uploaded") && ($activity->itemType()=="user")) { $activity_target = ''.$activity->user->fullName().''; - } elseif (($activity->item) && ($activity->target_type === "App\Models\Asset")) { - $activity_target = ''.$activity->target->showAssetName().''; + } elseif ($activity->target_type === "App\Models\Asset") { + if($activity->target) { + $activity_target = ''.$activity->target->showAssetName().''; + } else { + $activity_target = "Unknown Item"; + } } elseif ( $activity->target_type === "App\Models\User") { - $activity_target = ''.$activity->target->fullName().''; + if($activity->target()) { + $activity_target = ''.$activity->target->fullName().''; + } else { + $activity_target = 'Unknown User'; + } } elseif ($activity->action_type=='requested') { - $activity_target = ''.$activity->user->fullName().''; + if ($activity->user) { + $activity_target = ''.$activity->user->fullName().''; + } else { + $activity_target = 'Unknown User'; + } } else { - $activity_target = $activity->target->id; + if($activity->target) { + $activity_target = $activity->target->id; + } else { + $activity_target = "Unknown"; + } } @@ -681,7 +697,7 @@ class ReportsController extends Controller foreach ($customfields as $customfield) { $column_name = $customfield->db_column_name(); if (e(Input::get($customfield->db_column_name())) == '1') { - $row[] = $asset->$column_name; + $row[] = str_replace(",", "\,", $asset->$column_name); } } diff --git a/app/Http/Controllers/UsersController.php b/app/Http/Controllers/UsersController.php index 770b82ee03..0140f4e0c7 100755 --- a/app/Http/Controllers/UsersController.php +++ b/app/Http/Controllers/UsersController.php @@ -81,6 +81,7 @@ class UsersController extends Controller $permissions = config('permissions'); $userPermissions = Helper::selectedPermissionsArray($permissions, Input::old('permissions', array())); + $permissions = $this->filterDisplayable($permissions); $location_list = Helper::locationsList(); $manager_list = Helper::managerList(); @@ -233,6 +234,17 @@ class UsersController extends Controller * @param int $id * @return View */ + + private function filterDisplayable($permissions) { + $output = null; + foreach($permissions as $key=>$permission) { + $output[$key] = array_filter($permission, function($p) { + return $p['display'] === true; + }); + } + return $output; + } + public function getEdit($id = null) { try { @@ -249,7 +261,7 @@ class UsersController extends Controller $userGroups = $user->groups()->pluck('name', 'id'); $user->permissions = $user->decodePermissions(); $userPermissions = Helper::selectedPermissionsArray($permissions, $user->permissions); - + $permissions = $this->filterDisplayable($permissions); $location_list = Helper::locationsList(); $company_list = Helper::companyList(); $manager_list = Helper::managerList(); @@ -282,7 +294,6 @@ class UsersController extends Controller // permissions here before we update the user. $permissions = $request->input('permissions', array()); app('request')->request->set('permissions', $permissions); - // Only update the email address if locking is set to false if (config('app.lock_passwords')) { return redirect()->route('users')->with('error', 'Denied! You cannot update user information on the demo.'); @@ -333,7 +344,6 @@ class UsersController extends Controller $user->notes = e($request->input('notes')); $user->permissions = json_encode($request->input('permission')); - if ($user->manager_id == "") { $user->manager_id = null; } diff --git a/resources/views/layouts/default.blade.php b/resources/views/layouts/default.blade.php index 9bd361d98c..4efcce6c3a 100644 --- a/resources/views/layouts/default.blade.php +++ b/resources/views/layouts/default.blade.php @@ -126,41 +126,41 @@
+