From c1dcc222178ea97293228d08b68b701a4c9b5f3a Mon Sep 17 00:00:00 2001 From: Brady Wetherington Date: Thu, 24 Aug 2017 22:24:02 -0700 Subject: [PATCH] Refactor and improve Modal support for Assets (#3884) --- .../Controllers/Api/AssetModelsController.php | 2 +- app/Http/Controllers/AssetsController.php | 6 +- app/Http/Controllers/ModalController.php | 32 ++++++ resources/views/hardware/edit.blade.php | 105 +++++++----------- resources/views/modals/location.blade.php | 32 ++++++ resources/views/modals/model.blade.php | 41 +++++++ resources/views/modals/statuslabel.blade.php | 26 +++++ resources/views/modals/supplier.blade.php | 20 ++++ resources/views/modals/user.blade.php | 44 ++++++++ .../partials/forms/edit/status.blade.php | 2 +- .../partials/forms/edit/supplier.blade.php | 2 +- resources/views/partials/modals.blade.php | 90 --------------- routes/web.php | 17 +++ 13 files changed, 260 insertions(+), 159 deletions(-) create mode 100644 app/Http/Controllers/ModalController.php create mode 100644 resources/views/modals/location.blade.php create mode 100644 resources/views/modals/model.blade.php create mode 100644 resources/views/modals/statuslabel.blade.php create mode 100644 resources/views/modals/supplier.blade.php create mode 100644 resources/views/modals/user.blade.php delete mode 100644 resources/views/partials/modals.blade.php diff --git a/app/Http/Controllers/Api/AssetModelsController.php b/app/Http/Controllers/Api/AssetModelsController.php index 6fd3677fc7..7ef076710c 100644 --- a/app/Http/Controllers/Api/AssetModelsController.php +++ b/app/Http/Controllers/Api/AssetModelsController.php @@ -76,7 +76,7 @@ class AssetModelsController extends Controller $assetmodel->fill($request->all()); if ($assetmodel->save()) { - return response()->json(Helper::formatStandardApiResponse('success', $assetmodel, trans('admin/assetmodels/message.create.success'))); + return response()->json(Helper::formatStandardApiResponse('success', $assetmodel, trans('admin/models/message.create.success'))); } return response()->json(Helper::formatStandardApiResponse('error', null, $assetmodel->getErrors())); diff --git a/app/Http/Controllers/AssetsController.php b/app/Http/Controllers/AssetsController.php index 1a85aa4e75..30bf8bb209 100755 --- a/app/Http/Controllers/AssetsController.php +++ b/app/Http/Controllers/AssetsController.php @@ -116,9 +116,9 @@ class AssetsController extends Controller ->with('statuslabel_list', Helper::statusLabelList()) ->with('location_list', Helper::locationsList()) ->with('item', new Asset) - ->with('manufacturer', Helper::manufacturerList()) - ->with('category', Helper::categoryList('asset')) - ->with('statuslabel_types', Helper::statusTypeList()) + ->with('manufacturer', Helper::manufacturerList()) //handled in modal now? + ->with('category', Helper::categoryList('asset')) //handled in modal now? + ->with('statuslabel_types', Helper::statusTypeList()) //handled in modal now? ->with('users_list', Helper::usersList()) ->with('assets_list', Helper::assetsList()) ->with('locations_list', Helper::locationsList()); diff --git a/app/Http/Controllers/ModalController.php b/app/Http/Controllers/ModalController.php new file mode 100644 index 0000000000..7ae8c61427 --- /dev/null +++ b/app/Http/Controllers/ModalController.php @@ -0,0 +1,32 @@ +with('manufacturer', Helper::manufacturerList()) + ->with('category', Helper::categoryList('asset')); + } + + function statuslabel() { + return view('modals.statuslabel')->with('statuslabel_types', Helper::statusTypeList()); + } + + function supplier() { + return view('modals.supplier'); + } + + function user() { + return view('modals.user'); + } +} diff --git a/resources/views/hardware/edit.blade.php b/resources/views/hardware/edit.blade.php index b994e32f10..be98068a7a 100755 --- a/resources/views/hardware/edit.blade.php +++ b/resources/views/hardware/edit.blade.php @@ -39,7 +39,7 @@ {!! $errors->first('model_id', ' :message') !!}
- New + New
@@ -74,7 +74,7 @@
@can('users.create') - New + New @endcan
@@ -98,7 +98,7 @@ {!! $errors->first('assigned_location', ' :message') !!}
- New + New
@endif @@ -127,7 +127,7 @@ {!! $errors->first('rtd_location_id', ' :message') !!}
- New + New
@@ -160,7 +160,9 @@ @stop @section('moar_scripts') -@include('partials/modals') +{{-- Some room for the modals --}} +