ouyang/snipe-it
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use $request->input over Request::get()

Browse Source
This commit is contained in:
snipe
2019-12-11 11:09:54 -08:00
parent a5b180a9c6
commit c31e150935
17 changed files with 64 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/ViewAssetsController.php
+6 -6
View File
@@ -70,7 +70,7 @@ class ViewAssetsController extends Controller
public function getRequestItem($itemType, $itemId = null)
public function getRequestItem(Request $request, $itemType, $itemId = null)
{
$item = null;
$fullItemType = 'App\\Models\\' . studly_case($itemType);
@@ -94,7 +94,7 @@ class ViewAssetsController extends Controller
$logaction->target_id = $data['user_id'] = Auth::user()->id;
$logaction->target_type = User::class;
$data['item_quantity'] = Request::has('request-quantity') ? e(Request::get('request-quantity')) : 1;
$data['item_quantity'] = $request->has('request-quantity') ? e($request->input('request-quantity')) : 1;
$data['requested_by'] = $user->present()->fullName();
$data['item'] = $item;
$data['item_type'] = $itemType;
@@ -252,7 +252,7 @@ class ViewAssetsController extends Controller
return redirect()->to('account/view-assets')->with('error', trans('admin/users/message.error.asset_already_accepted'));
}
if (!Request::has('asset_acceptance')) {
if ($request->missing('asset_acceptance')) {
return redirect()->back()->with('error', trans('admin/users/message.error.accept_or_decline'));
}
@@ -274,7 +274,7 @@ class ViewAssetsController extends Controller
$logaction = new Actionlog();
if (Request::get('asset_acceptance')=='accepted') {
if ($request->input('asset_acceptance')=='accepted') {
$logaction_msg = 'accepted';
$accepted="accepted";
$return_msg = trans('admin/users/message.accepted');
@@ -288,7 +288,7 @@ class ViewAssetsController extends Controller
// Asset
if (($findlog->item_id!='') && ($findlog->item_type==Asset::class)) {
if (Request::get('asset_acceptance')!='accepted') {
if ($request->input('asset_acceptance')!='accepted') {
DB::table('assets')
->where('id', $findlog->item_id)
->update(array('assigned_to' => null));
@@ -297,7 +297,7 @@ class ViewAssetsController extends Controller
$logaction->target_id = $findlog->target_id;
$logaction->target_type = User::class;
$logaction->note = e(Request::get('note'));
$logaction->note = e($request->input('note'));
$logaction->updated_at = date("Y-m-d H:i:s");