ouyang/snipe-it
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add some sanity checks that the asset actually exists

Browse Source
This commit is contained in:
Scarzy
2024-05-01 19:01:33 +01:00
parent e817b20840
commit f11ea79406
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/Api/AssetFilesController.php
+11 -4
View File
@@ -83,7 +83,9 @@ class AssetFilesController extends Controller
*/
public function list($assetId = null)
{
$asset = Asset::find($assetId);
if (! $asset = Asset::find($assetId)) {
return response()->json(Helper::formatStandardApiResponse('error', null, trans('admin/hardware/message.does_not_exist')), 500);
}
// the asset is valid
if (isset($asset->id)) {
@@ -116,7 +118,10 @@ class AssetFilesController extends Controller
*/
public function show($assetId = null, $fileId = null)
{
$asset = Asset::find($assetId);
if (! $asset = Asset::find($assetId)) {
return response()->json(Helper::formatStandardApiResponse('error', null, trans('admin/hardware/message.does_not_exist')), 500);
}
// the asset is valid
if (isset($asset->id)) {
$this->authorize('view', $asset);
@@ -164,8 +169,10 @@ class AssetFilesController extends Controller
*/
public function destroy($assetId = null, $fileId = null)
{
$asset = Asset::find($assetId);
$this->authorize('update', $asset);
if (! $asset = Asset::find($assetId)) {
return response()->json(Helper::formatStandardApiResponse('error', null, trans('admin/hardware/message.does_not_exist')), 500);
}
$rel_path = 'private_uploads/assets';
// the asset is valid