ouyang/snipe-it
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve readability

Browse Source
This commit is contained in:
Marcus Moore
2023-12-21 12:15:00 -08:00
parent 5c0c60a5b9
commit 2eeaef00e1
1 changed files with 6 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/ReportTemplateTest.php
+6 -14
View File
@@ -87,33 +87,25 @@ class ReportTemplateTest extends TestCase
public function testSelectValuesDoNotIncludeDeletedOrNonExistentModels()
{
[$locationA, $locationB] = Location::factory()->count(2)->create();
$invalidId = 10000;
$savedReport = ReportTemplate::factory()->create([
'options' => [
'by_location_id' => [
$locationA->id,
$locationB->id,
10000
$invalidId,
],
],
]);
$locationB->delete();
$this->assertContains(
$locationA->id,
$savedReport->selectValues('by_location_id', Location::class)
);
$parsedValues = $savedReport->selectValues('by_location_id', Location::class);
$this->assertNotContains(
$locationB->id,
$savedReport->selectValues('by_location_id', Location::class)
);
$this->assertNotContains(
10000,
$savedReport->selectValues('by_location_id', Location::class)
);
$this->assertContains($locationA->id, $parsedValues);
$this->assertNotContains($locationB->id, $parsedValues);
$this->assertNotContains($invalidId, $parsedValues);
}
public function testGracefullyHandlesSingleSelectBecomingMultiSelect()