Merge pull request #11048 from Godmartinz/bug/sc-18989/purchase-cost-can-be-negative

Fixed validation for purchase cost allowed to be negative

app/Models/Accessory.php

@@ -61,7 +61,7 @@ class Accessory extends SnipeModel
         'category_id'       => 'required|integer|exists:categories,id',
         'company_id'        => 'integer|nullable',
         'min_amt'           => 'integer|min:0|nullable',
-        'purchase_cost'     => 'numeric|nullable',
+        'purchase_cost'     => 'numeric|nullable|gte:0',
     ];
 
 

app/Models/Asset.php

@@ -111,7 +111,7 @@ class Asset extends Depreciable
         'asset_tag'       => 'required|min:1|max:255|unique_undeleted',
         'status'          => 'integer',
         'serial'          => 'unique_serial|nullable',
-        'purchase_cost'   => 'numeric|nullable',
+        'purchase_cost'   => 'numeric|nullable|gte:0',
         'next_audit_date' => 'date|nullable',
         'last_audit_date' => 'date|nullable',
         'supplier_id'     => 'exists:suppliers,id|nullable',

app/Models/Component.php

@@ -36,7 +36,7 @@ class Component extends SnipeModel
         'company_id'     => 'integer|nullable',
         'min_amt'        => 'integer|min:0|nullable',
         'purchase_date'  => 'date|nullable',
-        'purchase_cost'  => 'numeric|nullable',
+        'purchase_cost'  => 'numeric|nullable|gte:0',
     ];
 
     /**

app/Models/Consumable.php

@@ -39,7 +39,7 @@ class Consumable extends SnipeModel
         'category_id' => 'required|integer',
         'company_id'  => 'integer|nullable',
         'min_amt'     => 'integer|min:0|nullable',
-        'purchase_cost'   => 'numeric|nullable',
+        'purchase_cost'   => 'numeric|nullable|gte:0',
     ];
 
     /**

app/Models/License.php

@@ -48,6 +48,7 @@ class License extends Depreciable
         'notes'   => 'string|nullable',
         'category_id' => 'required|exists:categories,id',
         'company_id' => 'integer|nullable',
+        'purchase_cost'=> 'numeric|nullable|gte:0',
     ];
 
     /**

resources/lang/en/validation.php

@@ -91,6 +91,10 @@ return [
     'url'                  => 'The :attribute format is invalid.',
     'unique_undeleted'     => 'The :attribute must be unique.',
     'non_circular'         => 'The :attribute must not create a circular reference.',
+    'gte'                  => [
+        'numeric'          => 'Value cannot be negative'
+    ],
+
 
     /*
     |--------------------------------------------------------------------------