ouyang/snipe-it
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

change \Throwable to \Exceptionm, add missing report()s

Browse Source
This commit is contained in:
spencerrlongg
2025-08-20 23:09:59 -05:00
parent b934f43db0
commit 643d44af22
5 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/Api/CategoriesController.php
+1 -1
View File
@@ -220,7 +220,7 @@ class CategoriesController extends Controller
return response()->json(
Helper::formatStandardApiResponse('error', null, trans('admin/categories/message.assoc_items', ['asset_type' => $category->category_type]))
);
} catch (\Throwable $e) {
} catch (\Exception $e) {
report($e);
return response()->json(
Helper::formatStandardApiResponse('error', null, trans('general.something_went_wrong'))
app/Http/Controllers/Api/ManufacturersController.php
+1
View File
@@ -199,6 +199,7 @@ class ManufacturersController extends Controller
} catch (ItemStillHasChildren $e) {
return response()->json(Helper::formatStandardApiResponse('error', null, trans('admin/manufacturers/message.assoc_users')));
} catch (\Exception $e) {
report($e);
return response()->json(Helper::formatStandardApiResponse('error', null, trans('general.something_went_wrong')));
}
app/Http/Controllers/Api/SuppliersController.php
+1
View File
@@ -207,6 +207,7 @@ class SuppliersController extends Controller
} catch (ItemStillHasLicenses $e) {
return response()->json(Helper::formatStandardApiResponse('error', null, trans('admin/suppliers/message.delete.assoc_licenses', ['licenses_count' => (int) $supplier->licenses_count])));
} catch (\Exception $e) {
report($e);
return response()->json(Helper::formatStandardApiResponse('error', null, trans('general.something_went_wrong')));
}
app/Http/Controllers/ManufacturersController.php
+1 -8
View File
@@ -173,17 +173,10 @@ class ManufacturersController extends Controller
} catch (ItemStillHasChildren $e) {
return redirect()->route('manufacturers.index')->with('error', trans('admin/manufacturers/message.assoc_users'));
} catch (\Exception $e) {
report($e);
return redirect()->route('manufacturers.index')->with('error', trans('general.something_went_wrong'));
}
// Soft delete the manufacturer if active, permanent delete if is already deleted
// do we really want to do that?...
// commenting it out for now because it's weird...
//if ($manufacturer->deleted_at === null) {
// $manufacturer->delete();
//} else {
// $manufacturer->forceDelete();
//}
return redirect()->route('manufacturers.index')->with('success', trans('admin/manufacturers/message.delete.success'));
}
app/Http/Controllers/SuppliersController.php
+1 -1
View File
@@ -135,7 +135,7 @@ class SuppliersController extends Controller
$errors->add('error', trans('admin/suppliers/message.delete.assoc_maintenances', ['asset_maintenances_count' => $supplier->asset_maintenances_count]));
} catch (ItemStillHasLicenses $e) {
$errors->add('error', trans('admin/suppliers/message.delete.assoc_licenses', ['licenses_count' => (int) $supplier->licenses_count]));
} catch (\Throwable $e) {
} catch (\Exception $e) {
report($e);
$errors->add('error', trans('general.something_went_wrong'));
}