ouyang/snipe-it
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add a couple of notes

Browse Source
This commit is contained in:
Marcus Moore
2025-08-19 15:54:46 -07:00
parent 3101212c49
commit d8eaf2676f
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/Feature/CheckoutAcceptances/Ui/AccessoryAcceptanceTest.php
View File

@@ -119,6 +119,7 @@ class AccessoryAcceptanceTest extends TestCase
'checkout_qty' => 2,
]);
// @todo: this is flaky
$this->assertEquals(2, AccessoryCheckout::count());
$legacyCheckoutAcceptance = CheckoutAcceptance::query()
@@ -142,6 +143,7 @@ class AccessoryAcceptanceTest extends TestCase
'checkout_qty' => 2,
]);
// @todo: this is flaky
$this->assertEquals(4, AccessoryCheckout::count());
$checkoutAcceptance = CheckoutAcceptance::query()
@@ -168,10 +170,12 @@ class AccessoryAcceptanceTest extends TestCase
'asset_acceptance' => 'declined',
]);
// both rows from `accessories_checkout` should be removed
// four rows from `accessories_checkout` should be removed
// @todo: this is flaky
$this->assertEquals(0, AccessoryCheckout::count());
// ensure existing checkouts for the user are not affected.
// in other words, make sure the removal of rows from `accessories_checkout` is not too eager, especially around legacy behavior.
// ie...if a user accepted previous accessories then those should not be touched.
}
}